Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FuzzyQuery produces a wrong result when prefix is equal to the term length #1002

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

paulirwin
Copy link
Contributor

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

FuzzyQuery produces a wrong result when prefix is equal to the term length

Fixes #941

Description

See #941

(NOTE: This PR was originally opened as #945 but included an unexpected commit. This PR cherry-picks that commit.)

@paulirwin paulirwin added this to the 4.8.0-beta00018 milestone Oct 29, 2024
@paulirwin paulirwin requested a review from NightOwl888 October 29, 2024 17:24
Copy link
Contributor

@NightOwl888 NightOwl888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the fact that the link to the original PR is not on this PR or on #941, this looks fine.

And here is the link: apache/lucene-solr#1545

@paulirwin
Copy link
Contributor Author

@NightOwl888 Thanks for finding the PR, I only included the commit hash in the comment as that was what I had found at the time.

@paulirwin paulirwin merged commit 98af2bb into apache:master Nov 4, 2024
199 checks passed
@paulirwin paulirwin deleted the issue/941 branch November 4, 2024 16:46
@NightOwl888 NightOwl888 added the notes:bug-fix Contains a fix for a bug label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes:bug-fix Contains a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FuzzyQuery produces a wrong result when prefix is equal to the term length
2 participants